Re: [PATCH] x86: Setup early console as early as possible

From: H. Peter Anvin
Date: Mon Jul 12 2010 - 14:11:10 EST


On 07/12/2010 10:44 AM, Cyrill Gorcunov wrote:
>
> Peter, while reviewing this patch I found another nit in
> context of early_param usage, so the patch is below. It's
> completely trivial. Actually I thought I've already fixed
> all early_param cases long ago but this one somehow sneaked ;)
>
> Anyway, Yinghai, Peter,
>
> I'm not sure but can't we use some boot_param "pad" field for
> "being copied" flag instead of new variable? There is a case
> when boot_param is used as __initdata and I'm not sure we clear
> this section explicitly.
>

Actually, even better would be to simply use boot_params.hdr.version,
which will never be zero.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/