Re: [PATCHv9 2.6.35-rc4-tip 11/13] perf: perf interface foruprobes

[Srikar Dronamraju]

> Before some more comments: this is getting really nice! Kudos!
> 

Thanks.

> > +
> > +	/* check if user has specifed a virtual address */
> > +	vaddr = strtoul(pp->function, NULL, 0);
> > +	session = perf_session__new(NULL, O_WRONLY, false, false);
> 
> At first creating a session here looks too much, lets see below...

Okay. 

> 
> > +	if (!vaddr)
> > +		symbol_conf.sort_by_name = true;
> > +	if (symbol__init() < 0) {
> > +		pr_warning("Cannot initialize symbols.\n");
> > +		goto free_session;
> > +	}
> 
> Configuring the symbol lib on a library function is a no-go, this
> function (symbol__init()) should be marked with the equivalent of
> "module_init()" on tools that need the symbol library, i.e. be called
> from the cmd_{top,report,probe,etc} level.


Oh okay, I then might be doing the same thing in patch 13/13. 
I will correct there too.

> 
> > +	event__synthesize_thread(pev->upid, event__process, session);
> > +	thread = perf_session__findnew(session, pev->upid);
> > +	if (!thread) {
> > +		pr_warning("Cannot initialize perf session.\n");
> > +		goto free_session;
> > +	}
> 
> Got it, you want to read an existing thread, get it into the
> perf_session threads rb_tree to then use what was parsed from /proc.
> 
> I think you should change event__synthesize_thread somehow to achieve
> taht same goal instead of going in such a roundabout way, unless you
> need the session for some other need.


Right, I need the session for the thread.

> 
> Probably we could change it to create a thread instance that then would
> be used to synthesize the MMAP and COMM events... but then for the
> existing use case we would be creating such events just to trow those
> objects away right after synthesizing the PERF_RECORD_{MMAP,COMM}
> events... perhaps duplicate them after all :-\
> 
> If I don't come with something for this quickly we can go on using what
> you coded and later refactor it to remove the fat.

Okay. I am fine either way.

> > +					struct probe_trace_event *tev)
> >  {
> > -	struct kprobe_trace_point *tp = &tev->point;
> > +	struct probe_trace_point *tp = &tev->point;
> >  	char pr;
> >  	char *p;
> >  	int ret, i, argc;
> >  	char **argv;
> >  
> > -	pr_debug("Parsing kprobe_events: %s\n", cmd);
> > +	pr_debug("Parsing probe_events: %s\n", cmd);
> 
> I suggest you put these s/kprobe/probe/g parts in a separate patch for
> easing review :)
> 

Okay . 

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/