Re: [PATCH 1/2] regulator: tps6507x: allow driver to useDEFDCDC{2,3}_HIGH register

From: Mark Brown
Date: Mon Jul 12 2010 - 06:40:51 EST


On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:

> +
> + /* Does DCDC high or the low register defines output voltage? */
> + bool defdcdc_high;

This should probably be "defdcdc_default" or something. Presumably the
line can also be wired to a GPIO and changed at runtime (otherwise the
feature seems at best odd) and if support for that is implemented then
this will change from being a static configuration in the platform data
to something configured dynamically so the name would no longer make
sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/