Re: [PATCH v2] x86: Early-boot serial I/O support

From: Pekka Enberg
Date: Sat Jul 10 2010 - 17:18:12 EST


On Sun, Jul 11, 2010 at 12:07 AM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
>> @@ -203,6 +205,17 @@ static inline int isdigit(int ch)
>>       return (ch >= '0') && (ch <= '9');
>>  }
>>
>> +static inline int isxdigit(int ch)
>> +{
>> +     if (isdigit(ch))
>> +             return true;
>> +
>> +     if ((ch >= 'a') && (ch <= 'f'))
>> +             return true;
>> +
>> +     return (ch >= 'A') && (ch <= 'F');
>> +}
>> +
>
> I suspect it's supposed to be static inline *bool*, right?

Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/