Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

From: David Brownell
Date: Thu Jul 08 2010 - 16:20:20 EST


> > Can it be made to do so only when the gadget
> > hasn't been provided with one already? Serial
> > number module options are standard parts of the
> > composite gadget framework...
>
> I don't see a way for the gadget to know whether user gave
> the iSerialNumber
> parameter (other then reading the iSerialNumber variable
> but I consider that ugly).

Uglier still is the current patch overriding
that explicitly-given parameter.

NAK until this issue is resolved.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/