Re: [PATCH] scsi/i2o: restore ioctl changes

From: Jens Axboe
Date: Thu Jul 08 2010 - 08:59:25 EST


On 2010-07-08 14:57, Arnd Bergmann wrote:
> This restores the changes from "scsi/i2o_block: cleanup ioctl
> handling", which accidentally got reverted.
>
> Origignal changelog:
> This fixes the ioctl function of the i2o_block driver, which
> has multiple problems:
>
> * The BLKI2OSRSTRAT and BLKI2OSWSTRAT commands always return
> -ENOTTY on success, where they should return 0.
> * Support for 32 bit compat is missing
> * The driver should use the .ioctl function and because
> .locked_ioctl is going away.
>
> The use of the big kernel lock remains for now, but gets
> made explictit in the ioctl function.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Jens, this is the commit that went missing due to my broken rebase.
> Please either apply on top of you for-next branch or fold into
> "block: push down BKL into .locked_ioctl", which reverted the change.

Thanks, I just applied this one on top to avoid rebasing things.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/