Re: [PATCH]video:gspca.c Fix warning: case value '7' not in enumeratedtype 'enum v4l2_memory'

[Justin P. Mattock]

On 07/07/2010 11:40 PM, Jean-Francois Moine wrote:
> On Wed,  7 Jul 2010 21:46:18 -0700
> "Justin P. Mattock"<justinmattock@xxxxxxxxx>  wrote:
>
> > This fixes a warning I'm seeing when building:
> >    CC [M]  drivers/media/video/gspca/gspca.o
> > drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
> > drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not
> > in enumerated type 'enum v4l2_memory'
>
> Hi Justin,
>
> I don't agree with your patch: the value GSPCA_MEMORY_READ must not be
> seen by user applications.
>
> The warning may be simply fixed by (change the line numbers):
>
> --- gspca.c~	2010-07-08 08:15:14.000000000 +0200
> +++ gspca.c	2010-07-08 08:28:52.000000000 +0200
> @@ -1467,7 +1467,8 @@ static int vidioc_reqbufs(struct file *f
>   	struct gspca_dev *gspca_dev = priv;
>   	int i, ret = 0, streaming;
>
> -	switch (rb->memory) {
> +	i = rb->memory;			/* (avoid compilation warning) */
> +	switch (i) {
>   	case GSPCA_MEMORY_READ:			/* (internal call) */
>   	case V4L2_MEMORY_MMAP:
>   	case V4L2_MEMORY_USERPTR:
>
> Cheers.


o.k. buddy.. make sense with the userspace etc..
Anyways looks good, builds without a warning..

Tested-By: Justin P. Mattock <justinmattock@xxxxxxxxx>

cheers as well,

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/