Re: [PATCH] time/fs - file's time race with vgettimeofday

From: john stultz
Date: Wed Jul 07 2010 - 13:21:14 EST


On Wed, 2010-07-07 at 19:11 +0200, Jiri Olsa wrote:
> On Tue, Jul 06, 2010 at 04:11:40PM -0700, john stultz wrote:
> > - vgettimeofday(&tv, NULL);
> > - result = tv.tv_sec;
> > + do {
> > + seq = read_seqbegin(&__vsyscall_gtod_data.lock);
> > +
> > + result = vsyscall_gtod_data.wall_time_sec;
> > +
> > + } while (read_seqretry(&__vsyscall_gtod_data.lock, seq));
> > +
> > if (t)
> > *t = result;
> > return result;
> >
> >
>
> I think there's a typo in using "vsyscall_gtod_data" inside
> the vtime call it should be "__vsyscall_gtod_data" intead.

Quite right! Thanks for catching it!
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/