Re: [PATCH] x86: KVM, fix lock imbalance

[Avi Kivity]

On 07/07/2010 04:07 PM, Jiri Slaby wrote:
> > A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It
> > should be at the end of the function, with goto labels, like we do it in
> > similar cases.
> >      
> Because the lock is around a block only. I usually don't create a goto
> fail-paths in these cases. Do you want one?
>    

In any case, the patch is a minimal fix, so I'll apply it.  Any clean 
ups can go on top.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/