Re: [PATCH 2/6] block: push down BKL into .open and .release

From: Christoph Hellwig
Date: Tue Jul 06 2010 - 21:50:11 EST


I might be missing something, but this doesn't actually push the
BKL anyway. It adds duplicate BKL locking inside the ->open and
->release methods without actually removing it in the callers.

That's a pretty pointless thing to do. If you're not feeling
confident enough about touching block_dev.c I can look into that
part of the pushdown, but this patch on it's own is not actually
useful.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/