Re: [PATCH] Rearrange i_flags to be consistent with FS_IOC_GETFLAGS

From: David Howells
Date: Tue Jul 06 2010 - 09:40:49 EST


Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> Further, it opens up the possibility that further down the track
> someone modifies S_* flag values (say when adding some XFS
> functionality) and corrupts extN filesystems all over the place.
> There isn't even compiler guards to catch someone modifying the S_*
> flags in a way that makes it incompatible with the extN on-disk
> definitions.

That occurred to me after I sent the patch. I can add some preprocessor guards
for this.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/