Re: Macbook Pro 5,5 nvidia backlight fix

From: Matthew Garrett
Date: Mon Jul 05 2010 - 13:26:02 EST


On Mon, Jul 05, 2010 at 05:27:00PM +0200, Martin Filip wrote:
> Maybe someone involved with this module can merge this one?

This is a really bad idea. You're hardcoding the location of PDISPLAY,
which the kernel is at liberty to remap at boot time, and even then
you're writing into the address space of a device that's controlled by
another driver. Does nouveau not handle this hardware properly?

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/