Re: [PATCH 10/13] Do not try to disable hpet if it hasn't been initializedbefore

From: Paolo Bonzini
Date: Fri Jul 02 2010 - 06:45:08 EST


On 06/21/2010 06:14 PM, stefano@xxxxxxxxxxxxxx wrote:
- if (is_hpet_capable()) {
- unsigned int cfg = hpet_readl(HPET_CFG);
+ unsigned int cfg;

You changed this earlier from unsigned long to unsigned int, but it is wrong (though it works because bits 32-63 of the HPET_CFG register are unused). Can you please make a note to change it back sometime?

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/