RE: [PATCH 8/9] dspbridge: add map support for big buffers

[Kanigeri, Hari]

Fernando,

> -	for_each_sg(sgt->sgl, sg, sgt->nents, i)
> -		sg_set_page(sg, usr_pgs[i], PAGE_SIZE, 0);
> +		da = iommu_vmap(mmu, da, sgt, IOVMF_ENDIAN_LITTLE |
> +							IOVMF_ELSZ_32);

-- iommu_vmap does the Kernel mapping to the buffers you are mapping to DSP MMU. Why do you need Kernel mappings ? 

If there is no benefit in maintaining Kernel mapping I would rather call iopgtable_store_entry directly to map the entries. 

Thank you,
Best regards, Hari
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/