RE: [PATCHv3 5/9] dspbridge: add mmufault support

From: Guzman Lugo, Fernando
Date: Thu Jul 01 2010 - 14:26:54 EST




> -----Original Message-----
> From: Kanigeri, Hari
> Sent: Thursday, July 01, 2010 1:04 PM
> To: Guzman Lugo, Fernando; linux-omap@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: ohad@xxxxxxxxxx; Hiroshi DOYU; ameya.palande@xxxxxxxxx;
> felipe.contreras@xxxxxxxxx
> Subject: RE: [PATCHv3 5/9] dspbridge: add mmufault support
>
> > > > + da = iommu_read_reg(mmu, MMU_FAULT_AD);
> > > > + iommu_write_reg(mmu, 0, MMU_IRQENABLE);
> > >
> > > -- Isn't the MMU already enabled at this point when the function
> > callback
> > > is called by iommu ?
> >
> > This line is actually disabling the interrupts. I am writing "0x0" in
> the
> > MMU_IRQENABLE.
>
> -- oops ! sorry about that. Didn't pay attention to 0x0. Yes, this should
> work.

Not problem :). Could you please comment in the second set of patches I sent? The previous ones have version 3 which is not correct, that was a version I was using internally, but the patches shouldn't have sent to mailing list with that version. Because it is the first version posted.

Thanks and regards,
Fernando.

>
> Best regards,
> Hari
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/