Re: [PATCH 26/33] Removing dead XSCALE_CACHE_ERRATA

From: Eric Miao
Date: Thu Jul 01 2010 - 00:26:09 EST


On Thu, Jul 1, 2010 at 12:02 AM, Christoph Egger <siccegge@xxxxxxxxx> wrote:
> XSCALE_CACHE_ERRATA doesn't exist in Kconfig, therefore removing all
> references for it from the source code.
>
> Signed-off-by: Christoph Egger <siccegge@xxxxxxxxx>

Acked-by: Eric Miao <eric.y.miao@xxxxxxxxx>

It's not been there since 2.6, found some references in 2.4 kernel though. And
I doubt anyone has encountered this issue in real products on market.

> ---
> Âarch/arm/mach-pxa/sleep.S | Â Â7 -------
> Â1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/sleep.S b/arch/arm/mach-pxa/sleep.S
> index 2ed95f3..52c30b0 100644
> --- a/arch/arm/mach-pxa/sleep.S
> +++ b/arch/arm/mach-pxa/sleep.S
> @@ -339,10 +339,6 @@ ENTRY(pxa_cpu_resume)
>    Âmcr   p15, 0, r1, c8, c7, 0      @ invalidate I & D TLBs
>    Âmcr   p15, 0, r1, c7, c7, 0      @ invalidate I & D caches, BTB
>
> -#ifdef CONFIG_XSCALE_CACHE_ERRATA
> -    bic   r9, r9, #0x0004         @ see cpu_xscale_proc_init
> -#endif
> -
>    Âmcr   p14, 0, r3, c6, c0, 0      @ clock configuration, turbo mode.
>    Âmcr   p15, 0, r4, c15, c1, 0     Â@ CP access reg
>    Âmcr   p15, 0, r5, c13, c0, 0     Â@ PID
> @@ -368,9 +364,6 @@ sleep_save_sp:
>
> Â Â Â Â.text
> Âresume_after_mmu:
> -#ifdef CONFIG_XSCALE_CACHE_ERRATA
> -    bl   Âcpu_xscale_proc_init
> -#endif
>    Âldmfd  sp!, {r2, r3}
> Â#ifndef CONFIG_IWMMXT
>    Âmar   acc0, r2, r3
> --
> 1.7.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/