Re: [PATCH v4] security: Yama LSM

From: Christian Stroetmann
Date: Wed Jun 30 2010 - 04:41:18 EST


Good morning;

On 30.06.2010 02:49, Kees Cook wrote:
Hi,

On Wed, Jun 30, 2010 at 09:18:32AM +1000, James Morris wrote:
On Mon, 28 Jun 2010, Kees Cook wrote:

This adds the Yama Linux Security Module to collect several security
features (symlink, hardlink, and PTRACE restrictions) that have existed
in various forms over the years and have been carried outside the mainline
kernel by other Linux distributions like Openwall and grsecurity.

Signed-off-by: Kees Cook<kees.cook@xxxxxxxxxxxxx>
There were no further complaints, and we seem to have reached a workable
consensus on the topic.

It's not clear yet whether existing LSMs will modify their base policies
to incorporate these protections, utilize the Yama code more directly, or
implement some combination of both.
I'm hoping we can implement really simple chaining -- nothing fancy.
Trying to chain comprehensive LSMs seems like it will always fail, but
putting little LSMs in front of big LSMs seems like an easy win.

No, I can't see why chaining of large LSMs will always fail and I don't think that the problem is if an LSM is small or large.
Furthermore, you have taken three protective functions out of other security packages that have good technical arguments why they are no LSMs and ported them into a new LSM. So what comes next? The next step is that you will put more and more functionalities, maybe again taken from other packages, into your new LSM with the result that at the end it will be a big LSM. And then?
While this is happening now you start to argue implicitly that the large LSMs have to follow your way, which means they have to be splitted into smaller LSMs. But the real problem is the LSM architecture must be in such a form that no protections have to be transformed by you at all.
And I think the future LSM architecture shouldn't be designed this time around another LSM, or in other words, around your LSM, but in a way that eg. grsecurity fits directly into it.

If you're a user of an existing LSM and want these protections, bug the
developers for a solution :-)

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

Thanks!

-Kees

Christian Stroetmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/