Re: [PATCH 3/3] Add a pair of system calls to make extended filestats available

[Sage Weil]

On Tue, 29 Jun 2010, David Howells wrote:
> Ulrich Drepper <drepper@xxxxxxxxx> wrote:
> 
> > On Tue, Jun 29, 2010 at 13:03, David Howells <dhowells@xxxxxxxxxx> wrote:
> > > Add a pair of system calls to make extended file stats available,
> > > including file creation time, inode version and data version where
> > > available through the underlying filesystem:
> > 
> > If you add something like this you might want to integrate another
> > extension.  This has been discussed a long time ago.  In almost no
> > situation all the information is needed.  Some of the pieces of
> > information returned by the syscall might be harder to collect than
> > other.
> 
> Trond mentioned this:
> 
> 	There has been a lot of interest in allowing the user to specify
> 	exactly which fields they want the filesystem to return, and whether
> 	or not the kernel can use cached data or not. The main use is to allow
> 	specification of a 'stat light' that could help speed up
> 	"readdir()+multiple stat()" type queries. At last year's Filesystem
> 	and Storage Workshop, Mark Fasheh actually came up with an initial
> 	design:
> 
> 	  http://www.kerneltrap.com/mailarchive/linux-fsdevel/2009/4/7/5427274
> 
> It'd be easy enough to absorb the functionality from that patch.

That would be nice.  HPC folks have been looking for this functionality 
for some time now.

> > It makes sense in such a situation to allow the caller to specify what she
> > is interested in.  A bitmask of some sort.
> 
> I have one of those.  See the query_flags field.  One question, though, is how
> to break things down.  Obvious groupings of the already extant stat stuff
> might be:
> 
> 	- st_dev, st_ino, st_mode, st_nlink, st_uid, st_gid, st_rdev, st_size
> 	- st_block, st_blksize
> 	- st_atime, st_mtime, st_ctime
> 
> However, what seems obvious to me might not be for some netfs or other.

The problem is that groupings that may seem logical now may not match 
reality for some specific file system for various implementation reasons.  
IMO a bit per field makes the most sense, with some simple way to include 
all fields (-1 or 0).  A mask argument that is separate from flags might 
make that simpler?

sage
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/