Re: [PATCH] parisc: set ARCH_KMALLOC_MINALIGN

From: Matt Turner
Date: Tue Jun 29 2010 - 10:07:35 EST


On Tue, Jun 29, 2010 at 2:50 AM, FUJITA Tomonori
<fujita.tomonori@xxxxxxxxxxxxx> wrote:
> This is a resend:
>
> http://marc.info/?t=127432584100006&r=1&w=2
>
> I thought that it was merged but seems that it was lost somewhere?
>
> =
> From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Subject: [PATCH] parisc: set ARCH_KMALLOC_MINALIGN
>
> Architectures that handle DMA-non-coherent memory need to set
> ARCH_KMALLOC_MINALIGN to make sure that kmalloc'ed buffer is DMA-safe:
> the buffer doesn't share a cache with the others.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Cc: Kyle McMartin <kyle@xxxxxxxxxxx>
> Cc: Helge Deller <deller@xxxxxx>
> Cc: James E.J. Bottomley <jejb@xxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
>  arch/parisc/include/asm/cache.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/parisc/include/asm/cache.h b/arch/parisc/include/asm/cache.h
> index 45effe6..5d87f27 100644
> --- a/arch/parisc/include/asm/cache.h
> +++ b/arch/parisc/include/asm/cache.h
> @@ -22,6 +22,8 @@
>  #define L1_CACHE_SHIFT 5
>  #endif
>
> +#define ARCH_KMALLOC_MINALIGN  L1_CACHE_BYTES
> +
>  #ifndef __ASSEMBLY__
>
>  #define L1_CACHE_ALIGN(x)       (((x)+(L1_CACHE_BYTES-1))&~(L1_CACHE_BYTES-1))

Looks like you can send a patch to kill L1_CACHE_ALIGN too. :)

> --
> 1.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/