Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used

[David Howells]

Justin P. Mattock <justinmattock@xxxxxxxxx> wrote:

> In this case the safest approach(in my mind) would be to just
> mark the integer __unused. Keep in mind though Im not certain 
> if this is the right place for this value i.e. will this effect
> *instkey or not(please check).

This is the wrong approach.  Either the variable should be got rid of, or it
should be used to replace all the other calls to key_ref_to_ptr() in
keyctl_describe_key().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/