Re: [PATCH] of/flattree: Use common ALIGN() macro instead of archspecific _ALIGN

From: Grant Likely
Date: Fri Jun 25 2010 - 19:34:43 EST


On Fri, Jun 25, 2010 at 5:18 PM, Stephen Neuendorffer
<stephen.neuendorffer@xxxxxxxxxx> wrote:
>> -----Original Message-----
>> From: glikely@xxxxxxxxxxxx [mailto:glikely@xxxxxxxxxxxx] On Behalf Of Grant Likely
>> Sent: Friday, June 25, 2010 4:16 PM
>> To: Stephen Neuendorffer
>> Cc: benh@xxxxxxxxxxxxxxxxxxx; monstr@xxxxxxxxx; microblaze-uclinux@xxxxxxxxxxxxxx; devicetree-
>> discuss@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; jeremy.kerr@xxxxxxxxxxxxx;
>> sfr@xxxxxxxxxxxxxxxx
>> Subject: Re: [PATCH] of/flattree: Use common ALIGN() macro instead of archspecific _ALIGN
>>
>> On Fri, Jun 25, 2010 at 4:49 PM, Stephen Neuendorffer
>> <stephen.neuendorffer@xxxxxxxxxx> wrote:
>> > Grant,
>> >
>> > I need this for the PCI project.  I also have a couple of other
>> > generalizations of the drivers/of code
>> > to get it to run after boot time in an X86 system...
>>
>> Send me your patches!  :-)  Get them to me soon and I'll queue them up
>> for the next merge window.
>>
>> g.
>
> Dangit, I just got the code compiling, and now I find out that X86 doesn't support out_be32()...  :)
> You'd think that somewhere somebody might have realized that all the duplicated driver macros that
> do that are a bad idea...

:-)

I think iowrite32be should be cross-arch safe. in_*, out_* was mostly
a powerpc/sparc thing.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/