Re: [RFC PATCH] Rework gpio cansleep (was Re: gpiolib and sleeping gpios)

From: David Brownell
Date: Fri Jun 25 2010 - 03:19:48 EST




--- On Wed, 6/23/10, Ryan Mallon <ryan@xxxxxxxxxxxxxxxx> wrote:

> >> In the current code, if a driver ever calls
> gpio_(set/get)_value on a
> >> gpio then you cannot pass a sleeping gpio to that
> driver. The request
> >> will succeed,

No it won't. Recall that those bit accessor
functions don't return success or failure!!

I'll be submitting a patch soonish, which is
a variant of Jani's patch to make the runtime
warnings trigger more consistently in the
face of such programming errors.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/