Re: [PATCH, v2] kbuild: Improve version string logic - two for theprice of one - No thanks

[David Rientjes]

On Mon, 7 Jun 2010, Boaz Harrosh wrote:

> Rrrr. If I wanted CONFIG_LOCALVERSION_AUTO, I would use that one. At least
> it is actually useful and informative.
> 
> I already have my:
>  VERSION = 2
>  PATCHLEVEL = 6
>  SUBLEVEL = 35
> -EXTRAVERSION = -rc2
> +EXTRAVERSION = -rc2-my_tree
> 

You shouldn't be using EXTRAVERSION for this purpose, you should be 
passing LOCALVERSION=my_tree to make.

> Which is managed by a git tree (for everybody based on my tree)
> 
> At least give us a way out with:
> CONFIG_LOCALVERSION_NO_AUTO_IM_REALLY_STUPID=y way out.
> 
> or EXTRAVERSION != $(git version)
> 
> But don't leave us cold in the woods like that. (What if I remove the git tree altogether, move to svn)
> 
> If I can shoot my self in the foot, it does not mean Government should not issue any more
> gun licenses.
> 
> I already have my outer Makefile system that makes sure I don't forget to compile, or
> "did I install this Kernel or not". Please let us have a way out?
> 

Unless it's a vanilla 2.6.35-rc2 kernel, it's inaccurate to persent it as 
2.6.35-rc2; you'll need to pass LOCALVERSION to make to identify this as a 
non-vanilla kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/