Re: hp_sdc_rtc: fix broken ioctl conversion

From: Geert Uytterhoeven
Date: Sun Jun 06 2010 - 07:17:55 EST


On Sat, Jun 5, 2010 at 22:52, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> Commit 55929332c92 "drivers: Push down BKL into various drivers"
> introduced a regression in hp_sdc_rtc, caused by a missing
> change of the .unlocked_ioctl pointer to the newly introduced
> function.
>
> On Saturday 05 June 2010, Geert Uytterhoeven wrote:
>> Something went wrong with this one:
>>
>> | drivers/input/misc/hp_sdc_rtc.c:681: warning: initialization from
>> incompatible pointer type
>> | drivers/input/misc/hp_sdc_rtc.c:665: warning:
>> âhp_sdc_rtc_unlocked_ioctlâ defined but not used
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/