Re: [PATCH] hugetlb: call mmu notifiers on hugepage cow

[Andrew Morton]

On Thu, 3 Jun 2010 10:36:00 -0700
Doug Doan <dougd@xxxxxxxx> wrote:

> > Well, specifically it means that
> > mmu_notifier_invalidate_range_start/end() implemetnations can no longer
> > take page_table_lock or any lock which nests outside page_table_lock.
> > That lessens flexibility.
> >
> > As the other mmu_notifier_invalidate_range_start/end() callsite in this
> > function carefully nested those calls outside page_table_lock, perhaps
> > that was thought to be a significant thing.
> 
> Here's my rationale: for the normal page case, the invalidation call is done 
> inside a page_table_lock,

It is?  Where does that happen?

> so the same should also be done in the huge page case. 
> Does it really make sense to call invalidation on one hugepage and have another 
> call invalidate the same hugepage while the first call is still not finished?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/