Re: [patch] fcntl: return -EFAULT if copy_to_user fails

[Al Viro]

On Thu, Jun 03, 2010 at 07:22:34PM +0900, Takuya Yoshikawa wrote:
> (2010/06/03 19:04), Dan Carpenter wrote:
> >copy_to_user() returns the number of bytes remaining, but we want to
> >return -EFAULT.
> >
> >	ret = fcntl(fd, F_SETOWN_EX, NULL);
> >
> >With the original code ret would be 8 here.
> >
> >Signed-off-by: Dan Carpenter<error27@xxxxxxxxx>
> 
> How about f_getown_ex() ?
> 
> 	if (!ret)
> 		ret = copy_to_user(owner_p, &owner, sizeof(owner));
> 	return ret;
> 
> Fixing this too would be better, I think.
> 
>   Takuya

Applied, will push today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/