Re: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes

[Alan Cox]

On Thu,  3 Jun 2010 13:55:02 +0200
Daniel Mack <daniel@xxxxxxxx> wrote:

> Call set_mctrl() and clear_mctrl() according to the flow control mode
> selected. This makes serial communication for FT232 connected devices
> work when CRTSCTS is not set.
> 
> This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> opened non blocking we still need to raise the carrier"). This patch
> calls the low-level driver's dtr_rts() function which consequently
> sets TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without
> CRTSCTS in cflags, however, does not reset these bits, and so data is
> not actually sent out on the serial wire.

If you've got hardware the other end expecting RTS/CTS signals you
really ought to set CRTSCTS. However you patch makes complete sense in
terms of which way it is best to end up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/