Re: [patch v2] fcntl: return -EFAULT if copy_to_user fails

[Takuya Yoshikawa]

(2010/06/03 20:59), Jens Axboe wrote:
> On 2010-06-03 12:35, Dan Carpenter wrote:
> > copy_to_user() returns the number of bytes remaining, but we want to
> > return -EFAULT.
> > 	ret = fcntl(fd, F_SETOWN_EX, NULL);
> > With the original code ret would be 8 here.
> >
> > V2: Takuya Yoshikawa pointed out a similar issue in f_getown_ex()
>
> Pretty basic bug, how long has this been there?

IIUC, from the beginning, when these were introduced.

And I recently sent similar bug fixes for other parts.

Ah, I also saw somebody sent cleanup patches using memdup_user() which does
not reside in uaccess.h.

Though I'm personally using private *_user documentation,
are there any good official doc for these?

  Takuya



> Acked-by: Jens Axboe<jaxboe@xxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/