Re: [PATCH 09/12] oom: remove PF_EXITING check completely

[David Rientjes]

On Thu, 3 Jun 2010, KOSAKI Motohiro wrote:

> Currently, PF_EXITING check is completely broken. because 1) It only
> care main-thread and ignore sub-threads

Then check the subthreads.

> 2) If user enable core-dump
> feature, it can makes deadlock because the task during coredump ignore
> SIGKILL.
> 

It may ignore SIGKILL, but does not ignore fatal_signal_pending() being 
true which gives it access to memory reserves with my patchset so that it 
may quickly finish.

> The deadlock is certenaly worst result, then, minor PF_EXITING
> optimization worth is relatively ignorable.
> 
> This patch removes it.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Nacked-by: David Rientjes <rientjes@xxxxxxxxxx>

You have no real world experience in using the oom killer for memory 
containment and don't understand how critical it is to protect other 
vital system tasks that are needlessly killed as the result of this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/