RE: [PATCH V2 1/4] Frontswap (was Transcendent Memory): swap datastructure changes

From: Dan Magenheimer
Date: Wed Jun 02 2010 - 20:13:16 EST


> > --- linux-2.6.34/include/linux/swap.h 2010-05-16 15:17:36.000000000
> -0600
> > +++ linux-2.6.34-frontswap/include/linux/swap.h 2010-05-24
> 10:13:41.000000000 -0600
> > @@ -182,6 +182,8 @@ struct swap_info_struct {
> > struct block_device *bdev; /* swap device or bdev of swap file
> */
> > struct file *swap_file; /* seldom referenced */
> > unsigned int old_block_size; /* seldom referenced */
> > + unsigned long *frontswap_map; /* frontswap in-use, one bit per
> page */
> > + unsigned int frontswap_pages; /* frontswap pages in-use counter
> */
>
> Is a 32-bit uint large enough? Maybe there are other things in swap
> which restrict us to less than 16TB, dunno.

Yes, the same data structure has "unsigned int pages" which is
the "total of usable pages" in the swap device. If/when
"pages" changes to an unsigned long (or long long), then
"frontswap_pages" should change also.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/