[PATCH] Fix colors for Mach64

From: Mikulas Patocka
Date: Wed Jun 02 2010 - 11:09:42 EST


Hi

The maintainer is nonexistent, so sending to Linus.

Mikulas

---

Use the same color-calculating algorithm as in atyfb_imageblit in this driver
or in generic cfb_fillrect.

This patch fixes bad colors when using an accelerator in 15-bit and 16-bit
modes.

Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>

---
drivers/video/aty/mach64_accel.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Index: linux-2.6.31-rc2-devel/drivers/video/aty/mach64_accel.c
===================================================================
--- linux-2.6.31-rc2-devel.orig/drivers/video/aty/mach64_accel.c 2009-07-07 15:56:15.000000000 +0200
+++ linux-2.6.31-rc2-devel/drivers/video/aty/mach64_accel.c 2009-07-07 16:08:03.000000000 +0200
@@ -242,7 +242,7 @@ void atyfb_copyarea(struct fb_info *info
void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
{
struct atyfb_par *par = (struct atyfb_par *) info->par;
- u32 color = rect->color, dx = rect->dx, width = rect->width, rotation = 0;
+ u32 color, dx = rect->dx, width = rect->width, rotation = 0;

if (par->asleep)
return;
@@ -253,8 +253,11 @@ void atyfb_fillrect(struct fb_info *info
return;
}

- color |= (rect->color << 8);
- color |= (rect->color << 16);
+ if (info->fix.visual == FB_VISUAL_TRUECOLOR ||
+ info->fix.visual == FB_VISUAL_DIRECTCOLOR)
+ color = ((u32 *)(info->pseudo_palette))[rect->color];
+ else
+ color = rect->color;

if (info->var.bits_per_pixel == 24) {
/* In 24 bpp, the engine is in 8 bpp - this requires that all */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/