Re: [Regression] [2.6.35-rc1] ssb_is_sprom_available

From: Maciej Rutecki
Date: Wed Jun 02 2010 - 10:20:28 EST


On wtorek, 1 czerwca 2010 o 15:34:02 John W. Linville wrote:
> On Mon, May 31, 2010 at 02:53:00PM -0600, Matthew Wilcox wrote:
> > On Mon, May 31, 2010 at 09:55:20PM +0200, Maciej Rutecki wrote:
> > > Last known good: 2.6.34
> > > Failing kernel: 2.6.35-rc1
> > >
> > > subsystem: PCI, USB(?)
> > >
> > > Kernel dies during booting on message "ssb_is_sprom_available", see
> > > picture:
> > > http://www.unixy.pl/maciek/download/kernel/2.6.35-rc1/gumis/DSC_0011.JP
> > >G
> >
> > Um, looks like it's something to do with the Sonics Silicon Backplane,
> > not PCI, nor USB.
>
> Fix is on its way...
>
> commit da1fdb02d9200ff28b6f3a380d21930335fe5429
> Author: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
> Date: Fri May 28 10:45:59 2010 +0200
>
> ssb: fix NULL ptr deref when pcihost_wrapper is used
>
> Ethernet driver b44 does register ssb by it's pcihost_wrapper
> and doesn't set ssb_chipcommon. A check on this value
> introduced with commit d53cdbb94a52a920d5420ed64d986c3523a56743
> and ea2db495f92ad2cf3301623e60cb95b4062bc484 triggers:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000010
> IP: [<c1266c36>] ssb_is_sprom_available+0x16/0x30
>
> Signed-off-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
>

Yes this commit solves problem. Thanks

Tested-by: Maciej Rutecki <maciej.rutecki@xxxxxxxxx>

--
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/