Re: [PATCH v2 1/1] perf tools: Make target to generate self containedsource tarball

From: Michal Marek
Date: Tue Jun 01 2010 - 06:29:19 EST


On 1.6.2010 01:06, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 31, 2010 at 10:11:24PM +0200, Michal Marek escreveu:
>> On 31.5.2010 19:42, Arnaldo Carvalho de Melo wrote:
>>> +git archive --prefix=$(perf-tar)/ HEAD^{tree} \
>>
>> If you use plain "HEAD" (a commit-ish) instead if HEAD^{tree}, then
>> git archive will store the commit id in the archive metadata and the
>> user can then use git get-tar-commit-id to extract it.
>
> I just used what was in git.git and then when talking with a git
> enthusiast, he showed me this:
>
> [acme@emilia git]$ git show 9cd625b79babaf50f50a0e5d96903eaacb1ee600
> commit 9cd625b79babaf50f50a0e5d96903eaacb1ee600
> Author: Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx>
> Date: Sun Jun 18 15:25:33 2006 +0200
>
> Make release tarballs friendlier to older tar versions

...

Ah, ok.


> Well, what about the other aspects of the patch, is this the only issue
> you have found with it?

The patch is OK.

Acked-by: Michal Marek <mmarek@xxxxxxx>

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/