[PATCH] pm_qos: remove unnecessary list-traversal

[Florian Mickler]

The new extreme_value is only depending on the old extreme_value and
the changing value.

Signed-off-by: Florian Mickler <florian@xxxxxxxxxxx>
---
 kernel/pm_qos_params.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index f42d3f7..6618e2c 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -136,6 +136,16 @@ static s32 min_compare(s32 v1, s32 v2)
 }
 
 
+static void update_target_val(int pm_qos_class, s32 val)
+{
+	s32 extreme_value;
+	s32 new_value;
+	extreme_value = atomic_read(&pm_qos_array[pm_qos_class]->target_value);
+	new_value = pm_qos_array[pm_qos_class]->comparitor(val,extreme_value);
+	if (extreme_value != new_value)
+		atomic_set(&pm_qos_array[pm_qos_class]->target_value,new_value);
+}
+
 static void update_target(int pm_qos_class)
 {
 	s32 extreme_value;
@@ -227,8 +237,8 @@ struct pm_qos_request_list *pm_qos_add_request(int pm_qos_class, s32 value)
 		spin_lock_irqsave(&pm_qos_lock, flags);
 		list_add(&dep->list,
 			&pm_qos_array[pm_qos_class]->requests.list);
+		update_target_val(pm_qos_class,dep->value);
 		spin_unlock_irqrestore(&pm_qos_lock, flags);
-		update_target(pm_qos_class);
 	}
 
 	return dep;
@@ -249,23 +259,21 @@ void pm_qos_update_request(struct pm_qos_request_list *pm_qos_req,
 		s32 new_value)
 {
 	unsigned long flags;
-	int pending_update = 0;
 	s32 temp;
 
 	if (pm_qos_req) { /*guard against callers passing in null */
+		int target = pm_qos_req->pm_qos_class;
 		spin_lock_irqsave(&pm_qos_lock, flags);
 		if (new_value == PM_QOS_DEFAULT_VALUE)
-			temp = pm_qos_array[pm_qos_req->pm_qos_class]->default_value;
+			temp = pm_qos_array[target]->default_value;
 		else
 			temp = new_value;
 
 		if (temp != pm_qos_req->value) {
-			pending_update = 1;
 			pm_qos_req->value = temp;
+			update_target_val(target,temp);
 		}
 		spin_unlock_irqrestore(&pm_qos_lock, flags);
-		if (pending_update)
-			update_target(pm_qos_req->pm_qos_class);
 	}
 }
 EXPORT_SYMBOL_GPL(pm_qos_update_request);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/