Re: [PATCH 4/5] oom: the points calculation of child processes must use find_lock_task_mm() too

From: KOSAKI Motohiro
Date: Mon May 31 2010 - 19:49:09 EST


> And, I think we need another patch on top of this one. Note that
> this list_for_each_entry(p->children) can only see the tasks forked
> by p, it can't see other children forked by its sub-threads.
>
> IOW, we need
>
> do {
> list_for_each_entry(c, &t->children, sibling) {
> ...
> }
> } while_each_thread(p, t);
>
> Probably the same for oom_kill_process().
>
> What do you think?

Makes perfectly sense. I have to do it!

Thanks good reviewing!




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/