Re: [Regression] [2.6.35-rc1] ssb_is_sprom_available

[Eric Dumazet]

Le lundi 31 mai 2010 Ã 21:55 +0200, Maciej Rutecki a Ãcrit :
> Last known good: 2.6.34
> Failing kernel: 2.6.35-rc1
> 
> subsystem: PCI, USB(?)
> 
> Kernel dies during booting on message "ssb_is_sprom_available", see picture:
> http://www.unixy.pl/maciek/download/kernel/2.6.35-rc1/gumis/DSC_0011.JPG
> 
> Config:
> http://www.unixy.pl/maciek/download/kernel/2.6.35-rc1/gumis/config-2.6.35-rc1
> 
> Regards

You could try following patch :

Followup of commit d53cdbb94a52a920d5420ed64d986c3523a56743
(ssb: do not read SPROM if it does not exist)

diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
index 007bc3a..af3cd4d 100644
--- a/drivers/ssb/sprom.c
+++ b/drivers/ssb/sprom.c
@@ -185,6 +185,7 @@ bool ssb_is_sprom_available(struct ssb_bus *bus)
 	/* this routine differs from specs as we do not access SPROM directly
 	   on PCMCIA */
 	if (bus->bustype == SSB_BUSTYPE_PCI &&
+	    bus->chipco.dev &&
 	    bus->chipco.dev->id.revision >= 31)
 		return bus->chipco.capabilities & SSB_CHIPCO_CAP_SPROM;
 





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/