Re: [PATCH] netfilter: xtables: stackptr should be percpu

[Eric Dumazet]

Le lundi 31 mai 2010 Ã 15:22 +0200, Jan Engelhardt a Ãcrit :
> On Monday 2010-05-31 15:13, Eric Dumazet wrote:
> >
> >All cpus share a single cache line for their 'stackptr' storage,
> >introduced in commit f3c5c1bfd4
> >
> >This is a stable candidate (2.6.34)
> 
> Stackptr was first introduced for 2.6.35-rcX.
> 

Indeed, I was fooled by 'git describe'

> >+	i->stackptr = alloc_percpu(unsigned int);
> > 	if (i->stackptr == NULL)
> > 		return -ENOMEM;
> >-	memset(i->stackptr, 0, size);
> > 
> > 	size = sizeof(void **) * nr_cpu_ids;
> > 	if (size > PAGE_SIZE)
> 
> Are alloc_percpu areas cleared?
> 

Yes, allocated chunks are cleared.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/