Re: [patch] caif: remove unneeded null check in caif_connect()

From: David Miller
Date: Mon May 31 2010 - 03:31:58 EST


From: Sjur Brændeland <sjurbren@xxxxxxxxx>
Date: Mon, 24 May 2010 21:56:01 +0200

> Dan Carpenter <error27@xxxxxxxxx> wrote:
>> We already dereferenced uaddr towards the start of the function when we
>> checked that "uaddr->sa_family != AF_CAIF".  Both the check here and the
>> earlier check were added in bece7b2398d0: "caif: Rewritten socket
>> implementation".  Before that patch, we assumed that we recieved a valid
>> pointer for uaddr, and based on that, I have removed this check.
>>
>> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> Thanks Looks good,
> Acked-by: Sjur Braendeland <sjur.brandeland@xxxxxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/