Re: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice_direct()

[Steven Rostedt]

On Sun, 2010-05-30 at 07:58 +0800, Changli Gao wrote:
> On Sun, May 30, 2010 at 12:20 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > [ Removed matthew@xxxxxx since I'm getting errors in sending to that address ]
> >

> But why not use (file->f_flags & O_NONBLOCK) instead, as
> tracing_splice_read_pipe() does?

Probably because I copied the code from something that used
SPLICE_F_NONBLOCK ;-)

But userspace passes that flag too. Although, maybe I just don't
understand the API fully.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/