Re: [PATCH] detour TTY driver

[Samo Pogacnik]

> > +static void initial_console_redirect(void)
> > +{
> > +	long ret;
> > +
> > +	/* re-register our fops write function */
> > +	detour_fops.write = detour_write;
> > +
> > +	detour_file.f_dentry = &detour_dentry;
> > +	detour_file.f_dentry->d_inode = &detour_inode;
> > +	detour_file.f_op = &detour_fops;
> > +	detour_file.f_mode |= FMODE_WRITE;
> > +	security_file_alloc(&detour_file);
> > +	INIT_LIST_HEAD(&detour_file.f_u.fu_list);
> > +
> > +	detour_inode.i_rdev = MKDEV(TTYAUX_MAJOR, 3);
> > +	security_inode_alloc(&detour_inode);
> > +	INIT_LIST_HEAD(&detour_inode.inotify_watches);
> > +
> > +	ret = detour_fops.open(&detour_inode, &detour_file);
> > +	printk(KERN_INFO "detour_fops.open() returned %ld\n", ret);
> > +	ret = detour_fops.unlocked_ioctl(&detour_file, TIOCCONS, 0);
> > +	printk(KERN_INFO "detour_fops.ioctl() returned %ld\n", ret);
> > +}
> 
> Bletch.. I'm really opposed to this kind of hackery. Fix your userspace a
> tiny bit.
> 
> So
> - Write only tty that uses printk: Looks good to me, implementation
>   quibbles only
> - Magic kernel hacks to shuffle things around in the initial console
>   logic - hideous. I still really think you need to fix your userspace
> 

Thank you for all comments. I'll try to follow them (might take some
time) and i'll remove the internal console redirection magic for sure. 

regards, Samo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/