Re: [PATCH 1/2] fs: optimize mpage_readpage()

From: Borislav Petkov
Date: Sat May 29 2010 - 09:46:33 EST


From: Changli Gao <xiaosuo@xxxxxxxxx>
Date: Sat, May 29, 2010 at 09:26:47PM +0800

> Did the compiler warning appear after applying my patch? It doesn't
> happen when I testing it.

yep, using gcc (Debian 4.4.4-2) 4.4.4 here.

> And I don't pass bio to do_mpage_readpage(), but I pass NULL instead.

True, but you still need that bio pointer so you might just as well set
it to NULL as the original code does.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/