Re: [PATCH 0/2] blackfin: ptrace mm/sram_list fixes

From: Oleg Nesterov
Date: Fri May 28 2010 - 15:45:04 EST


On 05/27, Mike Frysinger wrote:
>
> > BTW. Obviously sys_sram_alloc() can create multiple sram_list_struct
> > nodes with the same ->addr (with or without this patch), I hope this
> > is fine.
>
> how so ?

OOPS. Of course it can't, I was wrong.

> Blackfin is a nommu arch, so there should be no aliasing
> issues. each of the individual L1 sub-allocators manage a different
> address range, and none of those should return an address that is
> already in use.

Yes, I greatly misunderstood this code, to the point I didn't notice
where this "addr" actually comes from.

Thanks for your explanation,

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/