Re: [PATCH] fs: block cross-uid sticky symlinks

[Kees Cook]

Hi,

On Thu, May 27, 2010 at 11:40:26PM -0500, Serge E. Hallyn wrote:
> > +	if (S_ISLNK(inode->i_mode) &&
> 
> Q: is the S_ISLNK() check actually needed?

I guess not -- I would imagine this function would never be called if it
wasn't true, and the caller would probably run into bigger problems first
anyway.  I will drop this test.

Thanks,

-Kees

-- 
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/