Re: [PATCH] fs/compat_rw_copy_check_uvector: add missing compat_ptr call

From: Jeff Moyer
Date: Fri May 28 2010 - 11:32:09 EST


Heiko Carstens <heiko.carstens@xxxxxxxxxx> writes:

> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> A call to access_ok is missing a compat_ptr conversion. Introduced with
> b83733639a494d5f42fa00a2506563fbd2d3015d "compat: factor out
> compat_rw_copy_check_uvector from compat_do_readv_writev"
>
> fs/compat.c: In function 'compat_rw_copy_check_uvector':
> fs/compat.c:629: warning: passing argument 1 of '__access_ok' makes pointer from integer without a cast
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

Thanks for catching this. I'm ashamed I missed the compiler warning.
:(

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/