Re: [PATCH] panic: keep blinking in spite of long spin timer mode

From: Andi Kleen
Date: Fri May 28 2010 - 05:14:07 EST


On Fri, May 28, 2010 at 06:56:45AM +0900, TAMUKI Shoichi wrote:
> To keep panic_timeout accuracy when running under a hypervisor, the
> current implementation only spins on long time (1 second) calls to
> mdelay. That brings a good effect, but we must give up blinking even
> if we have a panic_blink.
>
> This patch keeps blinking in spite of long spin timer mode.
>
> We now have new kernel parameter (panic_longspin) to enable long spin
> timer mode when kernel panics. This is to be used when running under
> a hypervisor (default is disable).

Sorry I didn't understand the problem based on your description.

What exactly is the problem with the current code under your
hypervisor?

New parameters for this are probably not the right answer,
who would figure out when to set them.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/