Re: [microblaze-uclinux] Re: [Uclinux-dist-devel] [PATCH 1/2 v2] FLAT: split the stack & data alignments

From: Mike Frysinger
Date: Fri May 28 2010 - 00:58:15 EST


On Thu, May 27, 2010 at 19:15, David McCullough wrote:
> Jivin Mike Frysinger lays it down ...
>> On Thu, May 27, 2010 at 04:24, Michal Simek wrote:
>> > Mike Frysinger wrote:
>> >> The stack and data have different alignment requirements, so don't force
>> >> them to wear the same shoe. ??Increase the data alignment to match that
>> >> which the elf2flt linker script has always been using: 0x20 bytes. ??Not
>> >> only does this bring the kernel loader in line with the toolchain, but
>> >> it also fixes a swath of gcc tests which try to force larger alignment
>> >> values but randomly fail when the FLAT loader fails to deliver.
>> >
>> > Solve the problem on Microblaze:
>> >
>> > Tested-by: Michal Simek <monstr@xxxxxxxxx>
>> >
>> > Who will add it to mainline?
>>
>> if we can get the misc nommu peeps to agree on this (looking mostly at
>> David [McCullough] and Greg), then akpm will most likely expedite the
>> merge. Âi like to think they're the best FLAT experts out there ;).
>
> Did the latest patch include the changes Paul requested.
>
> It looks like it to me, ÂI've just been a bit distracted. ÂIf so I'll send
> in an Ack.

i dont want to rush you or something ... the patches need to be in
before 2.6.35 is released (since trouble started with a patched added
to 2.6.35 merge window), so if you want to review things a bit more,
it should be OK ..
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/