Re: linux-next: build failure in Linus' tree

From: Linus Torvalds
Date: Thu May 27 2010 - 21:12:35 EST




On Fri, 28 May 2010, Stephen Rothwell wrote:
>
> Caused by commit 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets:
> randomize node rotor used in cpuset_mem_spread_node()").
>
> This commit assumes that __node_random() exists if (MAX_NUMNODES > 1) and
> uses it if CONFIG_CPUSETS is set, but only creates it for x86 ... there
> is at least one other architecture where those conditions are true.

Yeah, looking at that, it seems totally idiotic.

Why is that "__node_random()" in x86 code at all? There is absolutely
nothing x86 about it that I can tell. And now I have an ia64 merge that
just duplicates that moronic function.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/