Re: [PATCH] Fix name of Xen event-channel device

[Bastian Blank]

On Thu, May 27, 2010 at 08:50:39PM +0400, Michael Tokarev wrote:
> Bastian Blank wrote:
> > The Xen event-channel device is named evtchn in the kernel but always
> > used as /dev/xen/evtchn in userspace. This patch fixes the name.
> > 
> > Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>
> > 
> > diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> > index 66e185c..89cd743 100644
> > --- a/drivers/xen/evtchn.c
> > +++ b/drivers/xen/evtchn.c
> > @@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
> >  
> >  static struct miscdevice evtchn_miscdev = {
> >  	.minor        = MISC_DYNAMIC_MINOR,
> > -	.name         = "evtchn",
> > +	.name         = "xen/evtchn",
> 
> Um.  Will existing userspace - esp. udev rules - continue
> to work after this change?

The udev rules will just not longer match, as they only rename the
device, this is no problem. However libxc _will_ break, as it lacks
proper error check in its own device creation routine.

However there are not much possibilities here: this support will go away
and it will annoy every user for some time.

>                             Also, how about other xen-related
> devices which are moved to /dev/xen in that same udev rules?

This is the only device currently supported by the vanilla kernel,
everything else is in the Xen tree only.

Bastian

-- 
Totally illogical, there was no chance.
		-- Spock, "The Galileo Seven", stardate 2822.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/