Re: [PATCH 2/4] [tip:x86/mm] Set first MB as RW+NX

[Siarhei Liakh]

On Thu, May 27, 2010 at 12:55 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> Hi,
>
>
> On Thu, 27 May 2010 12:52:21 -0400 Siarhei Liakh wrote:
>
>> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
>> index 4814d35..6dbcb6f 100644
>> --- a/arch/x86/Kconfig.debug
>> +++ b/arch/x86/Kconfig.debug
>> @@ -123,6 +123,17 @@ config DEBUG_NX_TEST
>>          and the software setup of this feature.
>>          If in doubt, say "N"
>>
>> +config DEBUG_SET_1ST_MB_RWNX
>> +       bool "Set 1st MB of kernel space mapping as RW+NX"
>> +       default n
>> +       depends on X86
>> +       ---help---
>> +         This option helps to catch unintended modifications/execution of
>> +         1st megabyte of kernel address space. Such protection may interfere
>> +         with run-time code patching and legacy BIOS services residing within
>> +         the 1st MB of physical address space.
>> +         If in doubt, say "N".
>
> Please spell out "first" instead of "1st" (all places in user-visible text).
>
> and gmail is space-stuffing your patches (converting tabs to spaces).
> Not good.  Are you using the gmail web interface for patches?
> That won't work AFAIK.  You'll need to use a real mail client.

Will do.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/