Re: [PATCH] fs: run emergency remount on dedicated workqueue

From: AmÃrico Wang
Date: Thu May 27 2010 - 10:54:14 EST


On Thu, May 27, 2010 at 11:57:23AM +0200, Tejun Heo wrote:
>Commit fa4b9074cd8428958c2adf9dc0c831f46e27c193 made s_umount depend
>on keventd; however, emergency remount schedules works to keventd
>which grabs s_umount creating a circular dependency. Run emergency
>remount on a separate workqueue to break it.
>


I have a stupid question, why using workqueue instead of
calling do_remount_sb() directly in emergency_remount()?
Avoid blocking emergency_remount()?

Thanks.

--
Live like a child, think like the god.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/